Skip to content

Conversation

@NA-V10
Copy link

@NA-V10 NA-V10 commented Nov 18, 2025

Summary

This PR adds a clear and beginner-friendly README.md to the examples/webserver/basic example in the Helidon examples repository. This example is usually the first place new users learn Helidon SE WebServer, so providing proper documentation significantly improves onboarding and clarity.

What’s Included

Added README.md explaining:

What the example demonstrates

How the WebServer starts

How routing works

Available endpoints

How to run the example

Tests included in the folder

Project structure

Ensures the example is easier to understand for beginners and new contributors.

Why This PR Is Useful

The basic example had no dedicated README, making it hard for new developers to understand how Helidon SE WebServer works.
This PR improves:

Learnability

Documentation quality

Onboarding experience

Consistency with other Helidon examples

Additional Notes

No production code was modified

Only documentation files were added

Fits Helidon’s style of example documentation

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Nov 18, 2025
@tvallin
Copy link
Member

tvallin commented Nov 18, 2025

Thanks for contributing to Helidon!

The helidon-4.x branch is a release branch, please create your PR against dev-4.x where the in progress work is located. Signing the OCA is still required.

@NA-V10 NA-V10 changed the base branch from helidon-4.x to dev-4.x November 18, 2025 09:04
@NA-V10 NA-V10 force-pushed the improve-basic-webserver-example branch from 83630bc to 761c80d Compare November 18, 2025 09:50
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The ASCII file tree needs to be escaped as a mono-spaced text block (three back-ticks).
  • There is no heading for the sections (the usual sections are build / run / exercise the application)
  • While the Unicode emojis are nice, it's not consistent with the other examples.

@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Nov 21, 2025
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix all headings.
Make sure to look at the rendered output.

@@ -0,0 +1,69 @@
##WebServer Basic Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need spaces after the #.
See

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants